tests(ourlogs): Add basic tests for ourlogs in events sections #97554
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Scope: Frontend
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| beforeEach(function () { | ||
| // the search query combobox is firing updates and causing console.errors | ||
| jest.spyOn(console, 'error').mockImplementation(() => {}); | ||
| }); |
There was a problem hiding this comment.
Bug: Unrestored Spy Masks Test Failures
The console.error spy is set up in beforeEach but not restored in afterEach. This global mutation can hide real errors in subsequent tests, leading to test pollution and masked failures. Restore the spy in afterEach (e.g., using jest.restoreAllMocks()).
k-fish
approved these changes
Aug 11, 2025
Zylphrex
deleted the
txiao/tests/add-basic-tests-for-ourlogs-in-events-sections
branch
andrewshie-sentry
pushed a commit
that referenced
this pull request
Aug 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.